Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Extractors pulling more items than required, leading to items flung out of pipes #5

Open
DrUltraLux opened this issue Apr 25, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@DrUltraLux
Copy link

DrUltraLux commented Apr 25, 2020

In this case a Furnace requests a log if it reaches 63 logs in the stack. A diamond extractor set to 1 item whitelisting logs, pulls the log from a chest and sends the log along the pipe. However it continues sending more logs along the pipe until the first log reaches the destination.
The furnace now full refuses more items and the remaining logs are flung out of the pipes onto the floor.

A complex setup involving redstone comparitors etc. can be used to solve this by pulsing a redstone signal to the extractor. However this seems against the spirit of the mod.

@aaronhowser1
Copy link

aaronhowser1 commented Mar 8, 2021

2021-02-06_17-30-29.mp4

Video of it

@raoulvdberge
Copy link
Contributor

I am working on a fix for this.

@raoulvdberge
Copy link
Contributor

raoulvdberge commented Mar 8, 2021

The issue is that it's basically just oversending. It has to take in account the items that are already on the way.

In theory this is easy to fix, but the accounting on the inventory destination side is hard to do since it's not possible to simulate insert batches of items, so we have to do an estimation, that would work most of the time.

@Darkere
Copy link

Darkere commented Mar 8, 2021

Additionally, I think if the estimation is unexpectedly wrong the Items should bounce back to the original inventory.

Optionally otherwise maybe play a sound when the item gets ejected?

Then there is also the problem of ending up with tons of items on the ground. Might need to check how many items are in the area before dropping anything.

@KhetagAb
Copy link

The issue is that it's basically just oversending. It has to take in account the items that are already on the way.

In theory this is easy to fix, but the accounting on the inventory destination side is hard to do since it's not possible to simulate insert batches of items, so we have to do an estimation, that would work most of the time.

Maybe just direct item to another side (don't pull it out)?

@dizzydis
Copy link

dizzydis commented Jun 8, 2021

Any chance of an update on this soon? Pretty frustrating

@uchihamaru
Copy link

uchihamaru commented Jul 28, 2021

Hi, i allready have same problem
i'm using the last version

@refinedmods refinedmods locked and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants