Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues from #32 #33

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

stellophiliac
Copy link

@stellophiliac stellophiliac commented Sep 23, 2024

#32

should also fix #16

@stellophiliac stellophiliac changed the title fix issues from #34 fix issues from #32 Sep 23, 2024
@stellophiliac
Copy link
Author

more issues pointed out here #32 (comment) , this pr isn't dead i'm just a little busy recently ^^ will continue working when i have time

@stellophiliac
Copy link
Author

most of what i've done seem to have been fixed in the actual repo at this point ^^ i can close the pr if that'd be preferred

@refact0r
Copy link
Owner

up to you

@stellophiliac stellophiliac marked this pull request as ready for review November 22, 2024 07:06
@stellophiliac
Copy link
Author

i think this is ready for review now, i did quite a bit so i lumped most of what i added in a section at the bottom of main.css

@refact0r
Copy link
Owner

image
image

@refact0r
Copy link
Owner

can you clarify which of the original issues this fixes exactly? it seems like most of them no longer exist in the current version of the theme.

@stellophiliac
Copy link
Author

  • color tab underlines (eg. "user profiles"/"server profiles" in profile settings)
  • status bubble coloring (fixed in upstream now)
  • modal coloring (fixed in upstream now)
  • make theme work better in light mode (fixed in upstream, i think? i still have some issues when using upstream in light mode though)
  • remove shadow on forum posts in grid view
  • color some things in channel search popups (eg. the date picker) (still some things here i haven't figured out how to color)
  • color placeholder text (eg. "where would you like to go?"
  • color audio controls
  • a lot of coloring on the call box & buttons, think most of them are fixed in upstream now
  • color the arrows on call buttons (ie. on the camera and mute buttons)
  • color embed titles(?) (ie. channel name in youtube embeds)
  • change the selector on the "input" title thing so it doesn't show up when searching for forum posts
  • add a bottom margin to forum thread banners (eg. "this post has been locked") so it doesn't overlap with the "messages" title

this should be most of it, a lot of my changes are to color variables that affect a lot of things. also many of them are just things i noticed or that were pointed out in the discord server

@refact0r
Copy link
Owner

refact0r commented Nov 23, 2024

see the images i posted above. it seems like the some of the changes in this pr will break some older fixes. you probably have to rebase or merge from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord status box in profile view not themed
2 participants