Color visibility of some note

[edcheyjr]

What docs page needs to be fixed?

Not a big problem but the color of the links under "Defining the mapDispatchToProps Function with bindActionCreators" does not seem visible will reading

• Section: Defining the mapDispatchToProps Function with bindActionCreators
• Page:Connect: Dispatching Actions with mapDispatchToProps

What is the problem?

The color of the links note under Defining the mapDispatchToProps Function with bindActionCreators

What should be changed to fix the problem?

the purple and grey color don't seem to make it visible while reading i would recommend changing the colors a bit

[EskiMojo14]

the contrast ratio between the background and foreground is 8.61, which passes both AA and AAA WCAG standards:

if we change it from primary-darkest back to the default of primary, it drops down to 5.43 which only passes AA:

i do agree that the links stand out less with the current primary-darkest colour though.

[edcheyjr]

Okay, thanks for the quick response. my concern is in dark mode. I don't know if in dark mode this is how the note should look like?

[EskiMojo14]

ah, you're right - that definitely doesn't look great

[EskiMojo14]

raised #2094 which fixes the background colour for codeblocks inside blockquotes

it's a little odd that blockquotes are light even during dark theme but this is at least consistent with that

[edcheyjr]

yeah.... i thought so.... but that's better