Pass shorthand arguments to reducers

[monvillalon]

Right now, in order to access the fsa properties you either have to use the the action argument directly or use destructuring:

handleActions({
  ACTION: (state, action ) => {
    return { ...state, data: action.payload.data, user: action.meta.user }
  },
  DESTRUCTURING: (state, { payload: { data }, meta: { user } }) => {
    return { ...state, filters, data, user }
  },
})

I'm proposing a third backward compatible form, that simplifies destructuring for the most common cases and I think looks pleasing and simpler, and makes it obvious those should
be the only properties of an fsa action

handleActions({
  SHORT_HAND_ARGS: (state, action, payload, meta, error ) => {
    return { ...state, data:payload.data, user: meta.user }
  },
  SHORT_HAND_DESTRUCTURING: (state, action, { data }, { meta }, error) => {
    return { ...state, filters, data, user }
  },
})

[yangmillstheory]

Great idea 👍, always a fan of reducing (no pun intended) boilerplate.

To clarify, should the SHORT_HAND_DESTRUCTURING example be

handleActions({
  SHORT_HAND_ARGS: (state, action, payload, meta, error ) => {
    return { ...state, data:payload.data, user: meta.user }
  },
  SHORT_HAND_DESTRUCTURING: (state, _, { data }, { user }, error) => {
    return { ...state, filters, data, user }
  },
})

Also, I wish there were a way to not have the unused argument. Can we introspect using length and act accordingly?

[yangmillstheory]

s/fsa/FSA, please

[yangmillstheory]

s/recieves/receives, and we can remove "gets" entirely.

[yangmillstheory]

Numbering here is incorrect, should be 2. Also I would say

the Flux Standard Action

instead of

the redux action

[chrisbendel]

PS markdown suggests using 1. multiple times

1. A
2. B
3. C

1. A
1. B
1. C

as it will auto increment numbers for you, and makes adding a step before/after later on not so tedious reordering all of the numbers

[yangmillstheory]

Spelling: "destructuring"

[yangmillstheory]

Can we destructure here:

const { payload, meta, error } = action
const hasError = error === true
return (hasError ? throwReducer : nextReducer)(state, action, payload, meta, hasError)