Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads are re-created everytime we start a new search #7

Open
reduf opened this issue Jan 13, 2023 · 0 comments
Open

Threads are re-created everytime we start a new search #7

reduf opened this issue Jan 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@reduf
Copy link
Owner

reduf commented Jan 13, 2023

This come with some cost, especially when incremental search are enable.

Unfortunately, it's currently baked in the crate we use to do the directory walk. See here: https://github.com/BurntSushi/ripgrep/blob/fe97c0a152cabc1bc07ec36b4b1e27cd230c3014/crates/ignore/src/walk.rs#L1285-L1304

@reduf reduf added the enhancement New feature or request label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant