gotohelm: restore to working order #348
Conversation
|
@RafalKorepta this doesn't fix any issues in the |
|
Ah this is probably in need of the licenseupdater change from #344 |
chrisseto
force-pushed
the
chris/p/fix-gotohelm
branch
from
8fb242c to
43867ba
Compare
Prior to this commit gotohelm failed to run post it's migration to this repository due to complications with `LoadPackages` and now being hosted in a new workspace layout. The root of this issue stemmed from the AST rewrites being performed on the bootstrap package which would introduce a dependency from `internal/bootstrap` to `helmette` for functions like `DictTest`, `Compact`, and `TypeTest`. This commit eliminates the helper functions and AST rewriting in favor of enhancing the transpiler itself. This allows the `internal/bootstrap` package to solely depend on the stdlib making it possible to load the package without any hijinks or dependency on cwd.
chrisseto
force-pushed
the
chris/p/fix-gotohelm
branch
from
43867ba to
aa9f859
Compare
|
So this does get gotohelm running again but there's a regression hiding around that I just uncovered. It seems that something in this PR make gotohelm drop |
|
Think I got a lead. It's the alias type messing with |
|
I think test failures are due to the retirement of the vectorized repo 😓 |
| // the identifiers on the LHS and position of the AssignStmt to get something that is unique, | ||
| // deterministic, and mildly human readable. | ||
| // foo, ok := ... -> $_123_foo_ok := ... | ||
| intermediate := &Ident{Name: fmt.Sprintf("_%d", stmt.Pos())} |
There was a problem hiding this comment.
I'm not sure why, but the stmt.Pos() is not stable. When this would be added to CI it will fail.
There was a problem hiding this comment.
Do you have an example failure I could see?
There was a problem hiding this comment.
Just re-run
go test ./pkg/gotohelm -v
Prior to this commit gotohelm failed to run post it's migration to this repository due to complications with
LoadPackagesand now being hosted in a new workspace layout.The root of this issue stemmed from the AST rewrites being performed on the bootstrap package which would introduce a dependency from
internal/bootstraptohelmettefor functions likeDictTest,Compact, andTypeTest.This commit eliminates the helper functions and AST rewriting in favor of enhancing the transpiler itself. This allows the
internal/bootstrappackage to solely depend on the stdlib making it possible to load the package without any hijinks or dependency on cwd.K8S-443