operator v1: alternative solution for drift detection with "null" #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #320 .
Instead of adding a special case for "null", use the existing method that normalizes the values already when talking to redpanda (writing cluster config).
This way, both ends are normalized via the same function:
The function used has a special case, similar to #320 : https://github.com/redpanda-data/redpanda-operator/blob/jb%2Fdrift-detection-alternative/operator/pkg/resources/configuration/patch.go#L106
This way, we don't need to have the "null" special code twice.
Very interested in review from @RafalKorepta , who may know this code better than i do.