Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPLICA commands missing in Sentinel #3371

Open
minrk opened this issue Sep 5, 2024 · 0 comments
Open

REPLICA commands missing in Sentinel #3371

minrk opened this issue Sep 5, 2024 · 0 comments

Comments

@minrk
Copy link

minrk commented Sep 5, 2024

Version: redis-py 5.0.8 , redis-server 7.2.5

Platform: macOS

Description:

Redis 5.0 deprecated SLAVE in most contexts in favor of REPLICA. The Python API and docs reflect this in many places, but it's still missing in some, particularly the Sentinel APIs, which do not implement the REPLICA commands or method names, only using the deprecated names.

I would expect these methods/classes to be defined, in order to match the redis server Sentinel API and documentation.

  • Sentinel.replica_for
  • .discover_replicas
  • .filter_replicas
  • SentinelConnectionPool.rotate_replicas
  • redis.sentinel.ReplicaNotFound

Also related:

  • Redis.client_kill_filter appears to not accept type=REPLICA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant