Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violated LSP in BlockingConnectionPool makes it impossible to inherit from it #3366

Open
vladvildanov opened this issue Sep 3, 2024 · 0 comments
Assignees
Labels
breakingchange API or Breaking Change bug Bug

Comments

@vladvildanov
Copy link
Collaborator

Version: What redis-py and what redis version is the issue happening on?
All

Platform: What platform / version? (For example Python 3.5.1 on Windows 7 / Ubuntu 15.10 / Azure)
All

Description: Description of your issue, stack traces from errors and code that reproduces the issue

LSP is violated inside of BlockingConnectionPool class, so disconnect() method implementation in it cannot substitute the implementation in super class, as arguments set (and behaviour) missmatches. It makes the class non-inheritable (f.e to implement SentinelBlockingConnectionPool), because of the interface changes

@vladvildanov vladvildanov added bug Bug breakingchange API or Breaking Change labels Sep 3, 2024
@vladvildanov vladvildanov self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change bug Bug
Projects
None yet
Development

No branches or pull requests

1 participant