Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenginer RedisModulesClient to enable Read from replica, Write to master #522

Open
ivanfrias opened this issue Oct 25, 2024 · 0 comments
Open

Comments

@ivanfrias
Copy link

ivanfrias commented Oct 25, 2024

Due to the high volume of reads, we need to diverge read operations to replicas.

We have created a ReadOnlyConnectionProvider that is injected into JedisSentineled. This provider has logic to understand if we are receiving a Search-type command.

The RedisModulesClient is responsible for initializing a Jedis client, based on the existing configuration. The only issue with this is that the getUnifiedJedis method is private and we can't extend it. We are currently copying class behaviour into our version of it, but this raises the question on how to keep track of change to the base class ( especially patches ).

We'd like to know if there are plans to enable overriding this class so clients can override it ( like we are doing).
Enabling this would bring Jedis closer to other libs like Lettuce in terms of feature-parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant