Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assisted | Add support to NATted networks #92

Merged
merged 9 commits into from
Jan 22, 2024
Merged

Assisted | Add support to NATted networks #92

merged 9 commits into from
Jan 22, 2024

Conversation

ramperher
Copy link
Contributor

@ramperher ramperher commented Dec 12, 2023 •
edited
Loading

Just retaking the change from redhat-partner-solutions/crucible#257 to include it in the collections

Test-Hints: assisted-abi

@ramperher ramperher requested a review from a team as a code owner December 12, 2023 14:33
@dcibot
Copy link
Collaborator

dcibot commented Dec 12, 2023

Starting dci-check-change job.

@ramperher
Copy link
Contributor Author

CC @nocturnalastro , if you remember, I started this work in this PR: redhat-partner-solutions/crucible#257, now I'll move it to the collections instead, since it's easier for us to test and troubleshoot

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/f4fc25b76b264641957b0d922d26b160

✔️ dci-rpm-build-el8 SUCCESS in 4m 04s
✔️ dci-rpm-build-el9 SUCCESS in 3m 32s

@dcibot
Copy link
Collaborator

dcibot commented Dec 12, 2023

@ramperher ramperher force-pushed the assisted-nat-network-mode branch from f251f2b to 8598f1d Compare December 12, 2023 16:43
@dcibot
Copy link
Collaborator

dcibot commented Dec 12, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/3f7e713907ce471eaf186e2a4aa86489

✔️ dci-rpm-build-el8 SUCCESS in 3m 28s
✔️ dci-rpm-build-el9 SUCCESS in 2m 56s

@ramperher ramperher changed the title Assisted | Add support to NATted networks [WIP] Assisted | Add support to NATted networks Dec 12, 2023
@dcibot
Copy link
Collaborator

dcibot commented Dec 12, 2023

@ramperher ramperher mentioned this pull request Dec 13, 2023
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/872a3588ee194910aa1a08545ed02c24

✔️ dci-rpm-build-el8 SUCCESS in 3m 58s
✔️ dci-rpm-build-el9 SUCCESS in 4m 04s

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b12124f59ad54b80b744c7894826c926

✔️ dci-rpm-build-el8 SUCCESS in 3m 31s
✔️ dci-rpm-build-el9 SUCCESS in 3m 30s

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a1e23be102224000b272bfbea30ad8cd

✔️ dci-rpm-build-el8 SUCCESS in 4m 00s
✔️ dci-rpm-build-el9 SUCCESS in 3m 25s

@nicomola
Copy link

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/00ac091998484da68c5833b3d8f33513

✔️ dci-rpm-build-el8 SUCCESS in 4m 06s
✔️ dci-rpm-build-el9 SUCCESS in 3m 40s

@nicomola
Copy link

@tkrishtop tkrishtop force-pushed the assisted-nat-network-mode branch from 95d48ca to 4833314 Compare December 18, 2023 16:52
@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Jan 8, 2024

@fredericlepied fredericlepied changed the title [WIP] Assisted | Add support to NATted networks Assisted | Add support to NATted networks Jan 10, 2024
@fredericlepied fredericlepied marked this pull request as draft January 10, 2024 22:32
@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@nicomola
Copy link

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8b9a170d69f0408bbbecbabf743d7379

✔️ dci-rpm-build-el8 SUCCESS in 3m 30s
✔️ dci-rpm-build-el9 SUCCESS in 3m 14s

@ramperher
Copy link
Contributor Author

The change is now validated in partners lab, and it's ready for review, CC @nocturnalastro

PD. In this partners' lab, we needed to do some changes in SELinux that we're now fixing. In the meantime, @tkrishtop created this for that case: #137

@ramperher ramperher marked this pull request as ready for review January 19, 2024 11:46
tkrishtop
tkrishtop approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@tkrishtop tkrishtop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested green: https://www.distributed-ci.io/jobs/5caa6ee5-8a48-49bb-8f6c-2d0b74bbef22/jobStates?sort=date

The SELinux fixes and automation will go into a separate PR

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

@nicomola
Copy link

@nocturnalastro
Copy link
Contributor

@ramperher Probably a good idea to squash your commits before the merge :)

@ramperher
Copy link
Contributor Author

@ramperher Probably a good idea to squash your commits before the merge :)

@nocturnalastro is it fine to leave the story as it is right now? since there are two contributors to this PR, maybe squashing the commits may disturb the story of this change. Also, the commits will be squashed for sure when merging. Here's an example: b2a4b70

@ramperher ramperher added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 22, 2024
@ramperher ramperher added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit f2fe3b9 Jan 22, 2024
7 checks passed
@ramperher ramperher deleted the assisted-nat-network-mode branch January 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrishtop tkrishtop tkrishtop approved these changes

@nocturnalastro nocturnalastro nocturnalastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramperher @dcibot @nicomola @thekad @nocturnalastro @tkrishtop