Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mirror from dir role #65

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Adding mirror from dir role #65

merged 2 commits into from
Nov 27, 2023

Conversation

betoredhat
Copy link
Contributor

No description provided.

@betoredhat betoredhat requested a review from a team as a code owner November 24, 2023 21:02
@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

  • dci-check-change preparation : KILLED tested on libvirt:virt

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/dc8f165852e94d438c1aed740e7c355c

✔️ dci-rpm-build-el8 SUCCESS in 3m 25s
✔️ dci-rpm-build-el9 SUCCESS in 10m 45s

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

  • dci-check-change preparation : KILLED tested on libvirt:virt

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2023

@dcibot
Copy link
Collaborator

dcibot commented Nov 25, 2023

ramperher
ramperher reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

roles/mirror_from_directory/README.md Outdated Show resolved Hide resolved
manurodriguez
manurodriguez approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@manurodriguez manurodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/9fb3b2d444a24594940e0281a04b5d54

✔️ dci-rpm-build-el8 SUCCESS in 12m 36s
✔️ dci-rpm-build-el9 SUCCESS in 3m 25s

@dcibot
Copy link
Collaborator

dcibot commented Nov 27, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Nov 27, 2023

@betoredhat betoredhat merged commit 841dc70 into main Nov 27, 2023
3 checks passed
@betoredhat betoredhat deleted the cat_mirror branch November 27, 2023 22:29
sf-project-io pushed a commit to redhat-cip/dci-openshift-agent that referenced this pull request Nov 27, 2023
@betoredhat
Adding mirror from file role
4f22b57 
- Moving logic to a role

build-depends: redhatci/ansible-collection-redhatci-ocp#65

Change-Id: Ic35e443debafc05b174c4326b6c126137af3ece8
betoredhat added a commit that referenced this pull request Nov 28, 2023
@betoredhat
Adding mirror from dir role (#65)
59c7cf6 
* Adding mirror from dir role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramperher ramperher ramperher left review comments

@manurodriguez manurodriguez manurodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betoredhat @dcibot @manurodriguez @ramperher