Replace repo_root_path with dci_cluster_configs_dir pinned in DOA

[tkrishtop]

Test-Hints: assisted-abi

Depends-On: https://github.com/dci-labs/inventories/pull/195

This is an attempt to fix the bug described here

[dcibot]

Starting dci-check-change job.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ca5fc22431774e93b913be6202346479

✔️ dci-rpm-build-el8 SUCCESS in 3m 18s
✔️ dci-rpm-build-el9 SUCCESS in 3m 15s

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:virt
• libvirt -> success: https://www.distributed-ci.io/jobs/df4acabf-c39f-4f2e-9e48-64d82cb31844/jobStates
• control_plane_example -> success: https://www.distributed-ci.io/jobs/ef730dca-a602-425b-8a59-284d6ad06efb/jobStates

[tkrishtop]

recheck

[tkrishtop]

recheck

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/1921fa5a4c7a4880962c01a9c19e3bb8

✔️ dci-rpm-build-el8 SUCCESS in 3m 11s
✔️ dci-rpm-build-el9 SUCCESS in 2m 59s

[nocturnalastro]

We have to think of backward compatibility with pre-existing crucible inventories. What about defaulting repo_root_path to dci_cluster_configs_dir. then in the inventory validation we can check if either are defined.
That way dci can use dci_cluster_configs_dir and we don't break anyone's inventories.

[tkrishtop]

We have to think of backward compatibility with pre-existing crucible inventories. What about defaulting repo_root_path to dci_cluster_configs_dir. then in the inventory validation we can check if either are defined.

Thank you @nocturnalastro, I see the point. Let's do as you propose, let me push the changes.

[dcibot]

Starting dci-check-change job.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c0602298d47b46aebdf4268caac686e7

✔️ dci-rpm-build-el8 SUCCESS in 3m 33s
✔️ dci-rpm-build-el9 SUCCESS in 3m 36s

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/ff803bb8-a088-464f-b40e-872981a2b26d/jobStates
• control_plane_example -> success: https://www.distributed-ci.io/jobs/6226bee1-fa99-4441-859b-e0ac6dd3b7b2/jobStates

[tkrishtop]

We have to think of backward compatibility with pre-existing crucible inventories. What about defaulting repo_root_path to dci_cluster_configs_dir. then in the inventory validation we can check if either are defined.

Thank you @nocturnalastro, I see the point. Let's do as you propose, let me push the changes.

Hi @nocturnalastro, I made the changes you requested and tested on assisted-abi installation: https://www.distributed-ci.io/jobs/ff803bb8-a088-464f-b40e-872981a2b26d/jobStates?sort=date

Could you please have a look one more time?

[tonyskapunk]

I'm not sure the roles should use a dci variable coming from the dci openshift agent. Would it be possible to make repo_root_path: dci_cluster_configs_dir as a var when called from the agent instead?

[ramperher]

I'm not sure the roles should use a dci variable coming from the dci openshift agent. Would it be possible to make repo_root_path: dci_cluster_configs_dir as a var when called from the agent instead?

Yes, I agree with @tonyskapunk , maybe it's better to set up that variable when calling these roles from the agent.

[tkrishtop]

I'm not sure the roles should use a dci variable coming from the dci openshift agent. Would it be possible to make repo_root_path: dci_cluster_configs_dir as a var when called from the agent instead?

Hi @tonyskapunk thanks for the idea, makes sense. Let me try it out.

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/7cf8d33f-3378-4d38-b950-aaae5bce90b3/jobStates
• control_plane_example -> success: https://www.distributed-ci.io/jobs/6a205f7e-1af6-454f-8657-bacbe7329819/jobStates

[thekad]

agreed with @tonyskapunk these roles are not DCI specific so they shouldn't rely on DCI variables. There's two ways you can do this:

• Do what Tony said and alter it on the calling playbook (easier, cleaner)
• Add an extra variable default_repo_root_path and alter that one (somewhat dirtier, but more flexible maybe)

I'd go with Tony's way, and only adjust these roles in a non-DCI way.

[tkrishtop]

agreed with @tonyskapunk these roles are not DCI specific so they shouldn't rely on DCI variables. There's two ways you can do this:

• Do what Tony said and alter it on the calling playbook (easier, cleaner)
• Add an extra variable default_repo_root_path and alter that one (somewhat dirtier, but more flexible maybe)

I'd go with Tony's way, and only adjust these roles in a non-DCI way.

agree, I'm testing with the current way just to ensure that all the dependencies are taken into account. Once it's green, I'll move the repo_root_path definition in the agent during the roles' invocation.

[tkrishtop]

check dallas ocp-4.14-vanilla-abi

[dcibot]

from change #140:

• ERROR https://www.distributed-ci.io/jobs/838f16e9-8135-4bca-b6f8-823d6737510f/jobStates

[tkrishtop]

Went for DOA + inventories change:

• https://softwarefactory-project.io/r/c/dci-openshift-agent/+/30767
• https://github.com/dci-labs/inventories