Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom virt module #14

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Remove custom virt module #14

merged 1 commit into from
Jan 6, 2024

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Oct 17, 2023 •
edited by fredericlepied
Loading

Use community.libvirt instead of custom module
Baremetal deploy role used a custom libvirt module, which was a copy of
an old libvirt module. The current functionality of the community module
is enough to stop using the custom module.

Test-Hints: sno

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Unable to update github.com/redhatci/ansible-collection-redhatci-ocp

@tonyskapunk
Copy link
Contributor Author

check dallas ocp-4.13-vanilla

1 similar comment
@tonyskapunk
Copy link
Contributor Author

check dallas ocp-4.13-vanilla

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2023

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2023

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2023

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2023

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2023

@tonyskapunk
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/5e02f7a5163948e784976597f75d87a9

✔️ dci-rpm-build-el8 SUCCESS in 6m 06s
✔️ dci-rpm-build-el9 SUCCESS in 3m 07s

@tonyskapunk
Copy link
Contributor Author

check dallas ocp-4.14-vanilla

@dcibot
Copy link
Collaborator

dcibot commented Oct 20, 2023

betoredhat
betoredhat previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@betoredhat betoredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyskapunk tonyskapunk mentioned this pull request Nov 13, 2023
Closed
@fredericlepied fredericlepied force-pushed the deprecate_custom_bm_virt_module branch from 9535841 to 5775432 Compare December 15, 2023 17:32
@dcibot
Copy link
Collaborator

dcibot commented Dec 15, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d2467a08b1984491b0c0958e29eaa0fc

✔️ dci-rpm-build-el8 SUCCESS in 4m 03s
✔️ dci-rpm-build-el9 SUCCESS in 3m 05s

@dcibot
Copy link
Collaborator

dcibot commented Dec 15, 2023

@dcibot
Copy link
Collaborator

dcibot commented Dec 15, 2023

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/6e49e8cbdfa94a9d96f212da3d689f5d

✔️ dci-rpm-build-el8 SUCCESS in 3m 42s
✔️ dci-rpm-build-el9 SUCCESS in 3m 07s

@dcibot
Copy link
Collaborator

dcibot commented Dec 15, 2023

@tonyskapunk tonyskapunk force-pushed the deprecate_custom_bm_virt_module branch from e7ac455 to 663ab73 Compare January 3, 2024 16:53
@dcibot
Copy link
Collaborator

dcibot commented Jan 3, 2024

Starting dci-check-change job.

@tonyskapunk tonyskapunk force-pushed the deprecate_custom_bm_virt_module branch from 663ab73 to cc3e15c Compare January 3, 2024 16:54
@dcibot
Copy link
Collaborator

dcibot commented Jan 3, 2024

  • dci-check-change preparation : KILLED tested on libvirt:virt

@dcibot
Copy link
Collaborator

dcibot commented Jan 3, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ded8535bf9bb43f2a9c5f0b1f95ed3cc

✔️ dci-rpm-build-el8 SUCCESS in 3m 35s
✔️ dci-rpm-build-el9 SUCCESS in 5m 05s

@dcibot
Copy link
Collaborator

dcibot commented Jan 3, 2024

@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@fredericlepied fredericlepied force-pushed the main branch 2 times, most recently from 9a6d481 to d95a66e Compare January 6, 2024 17:09
@fredericlepied fredericlepied removed this pull request from the merge queue due to a manual request Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@fredericlepied fredericlepied removed this pull request from the merge queue due to a manual request Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2024
@fredericlepied
Merge pull request #14 from redhatci/deprecate_custom_bm_virt_module
33a483a 
Remove custom virt module
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@fredericlepied fredericlepied removed this pull request from the merge queue due to a manual request Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
@fredericlepied fredericlepied removed this pull request from the merge queue due to the queue being cleared Jan 6, 2024
@fredericlepied fredericlepied added this pull request to the merge queue Jan 6, 2024
Merged via the queue into main with commit ad2b25d Jan 6, 2024
7 checks passed
@fredericlepied fredericlepied deleted the deprecate_custom_bm_virt_module branch January 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericlepied fredericlepied fredericlepied approved these changes

@betoredhat betoredhat betoredhat left review comments

@pierreblanc pierreblanc pierreblanc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonyskapunk @dcibot @fredericlepied @pierreblanc @betoredhat