Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crucible | Update possible responses received from KVM Force Power On System #115

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Crucible | Update possible responses received from KVM Force Power On System #115

merged 7 commits into from
Jan 5, 2024

Conversation

ramperher
Copy link
Contributor

@ramperher ramperher commented Jan 4, 2024 •
edited
Loading

Test-Hints: assisted-abi

@ramperher ramperher requested a review from a team as a code owner January 4, 2024 10:59
@ramperher ramperher requested a review from tkrishtop January 4, 2024 10:59
@ramperher
Copy link
Contributor Author

CC @tkrishtop

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@ramperher ramperher mentioned this pull request Jan 4, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/3d534b4d907b4ccb94238b161b4822d5

✔️ dci-rpm-build-el8 SUCCESS in 3m 38s
✔️ dci-rpm-build-el9 SUCCESS in 3m 19s

@ramperher
Copy link
Contributor Author

I don't get the point of the failure in the Pull Request / Ansible-lint Check (pull_request), since it's complaining about code that is not being changed in this PR. I suppose that, after a green job, it should be fine to merge this.

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/de6da69167cc43e281c76dcd1f2c8df0

✔️ dci-rpm-build-el8 SUCCESS in 3m 32s
✔️ dci-rpm-build-el9 SUCCESS in 3m 04s

tkrishtop
tkrishtop requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tkrishtop tkrishtop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramperher if you want to move the commits from one PR to another, it's better to use git cherry-pick comment_hash to avoid merge conflicts and to keep the author. Thanks.

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d9dd074d40ef44b1a7bf10f869a5ea3a

✔️ dci-rpm-build-el8 SUCCESS in 3m 45s
✔️ dci-rpm-build-el9 SUCCESS in 3m 10s

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@ramperher ramperher requested a review from tkrishtop January 4, 2024 14:01
@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@ramperher
Copy link
Contributor Author

@ramperher if you want to move the commits from one PR to another, it's better to use git cherry-pick comment_hash to avoid merge conflicts and to keep the author. Thanks.

Wow, I was not aware of this, thanks for the recommendation. I've applied that and now your commit from the other PR is in this one, then I've corrected what was required, regarding the URL.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2c3dd95dadc846d3ba48b9478756e017

✔️ dci-rpm-build-el8 SUCCESS in 4m 01s
✔️ dci-rpm-build-el9 SUCCESS in 4m 03s

@ramperher ramperher force-pushed the crucible-kvm-power-on branch from 17d8779 to f5bbd20 Compare January 4, 2024 14:46
@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/84e14b8c83b24f5aac908d4bb45468f5

✔️ dci-rpm-build-el8 SUCCESS in 4m 02s
✔️ dci-rpm-build-el9 SUCCESS in 3m 43s

@tkrishtop
Copy link
Contributor

@ramperher if you want to move the commits from one PR to another, it's better to use git cherry-pick comment_hash to avoid merge conflicts and to keep the author. Thanks.

Wow, I was not aware of this, thanks for the recommendation. I've applied that and now your commit from the other PR is in this one, then I've corrected what was required, regarding the URL.

Let's do git revert fd97ce740ebea5b49d425b7c64aacffc67fd1cba as well. Currently, this commit is modifying the same line in priority and may produce a merge conflict: fd97ce7

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

  • dci-check-change preparation : FAILURE tested on libvirt:assisted-abi

@ramperher
Copy link
Contributor Author

@ramperher if you want to move the commits from one PR to another, it's better to use git cherry-pick comment_hash to avoid merge conflicts and to keep the author. Thanks.

Wow, I was not aware of this, thanks for the recommendation. I've applied that and now your commit from the other PR is in this one, then I've corrected what was required, regarding the URL.

Let's do git revert fd97ce740ebea5b49d425b7c64aacffc67fd1cba as well. Currently, this commit is modifying the same line in priority and may produce a merge conflict: fd97ce7

Done

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

Starting dci-check-change job.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/20acfc3d01da41cf9889d5c3c9fff311

✔️ dci-rpm-build-el8 SUCCESS in 3m 38s
✔️ dci-rpm-build-el9 SUCCESS in 3m 01s

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@ramperher
Copy link
Contributor Author

Change is working and it's ready for review, CC @tkrishtop and @nocturnalastro

tkrishtop
tkrishtop approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tkrishtop tkrishtop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramperher

@ramperher ramperher merged commit b2a4b70 into main Jan 5, 2024
6 checks passed
@ramperher ramperher deleted the crucible-kvm-power-on branch January 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrishtop tkrishtop tkrishtop approved these changes

@nocturnalastro nocturnalastro nocturnalastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramperher @dcibot @tkrishtop @nocturnalastro