CI: output fixes #102

fredericlepied · 2023-12-19T21:56:27Z

sanity: capture the output for all the versions of Python for the summary
ansible-lint: display the output of ansible-lint on the PR in the job detail view
ansible-lint: use colors like in Sanity Check
check-all-dependencies-are-merged: do not checkout the code

softwarefactory-project-zuul · 2023-12-19T22:02:41Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/40c6ff8255264ab3a09a74a6d8fd89fa

✔️ dci-rpm-build-el8 SUCCESS in 3m 29s
✔️ dci-rpm-build-el9 SUCCESS in 3m 21s

softwarefactory-project-zuul · 2023-12-19T22:10:18Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/06e0d6c1f9ad450b86c867ff001430ae

✔️ dci-rpm-build-el8 SUCCESS in 3m 23s
✔️ dci-rpm-build-el9 SUCCESS in 3m 06s

.github/workflows/pr.yml

softwarefactory-project-zuul · 2023-12-19T23:15:30Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/37338ff2443047b0a9dcc21c8329ba77

✔️ dci-rpm-build-el8 SUCCESS in 3m 28s
✔️ dci-rpm-build-el9 SUCCESS in 2m 56s

dcibot · 2023-12-19T23:24:03Z

Starting dci-check-change job.

softwarefactory-project-zuul · 2023-12-19T23:26:41Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b1f8e0bd765a476686b6ef4cab230b7f

✔️ dci-rpm-build-el8 SUCCESS in 3m 26s
✔️ dci-rpm-build-el9 SUCCESS in 3m 24s

thekad · 2023-12-19T23:27:57Z

your PR title says fix the sanity check, but you're changing the ansible-lint check
the output is exactly the same as the previous output, but you're making it harder by forcing color output then striping the colors out of it, what exactly are you trying to accomplish here?

tonyskapunk · 2023-12-19T23:32:42Z

I can answer about this one 😸

2. the output is exactly the same as the previous output, but you're making it harder by forcing color output then striping the colors out of it, what exactly are you trying to accomplish here?

The output is different as it includes coloring in the step when ansible-lint is running, here: https://github.com/redhatci/ansible-collection-redhatci-ocp/actions/runs/7268748379/job/19805160605?pr=102#step:6:162 vs https://github.com/redhatci/ansible-collection-redhatci-ocp/actions/runs/7267875512/job/19802603666#step:6:44

The end result is, 1. Visually better output in the detailed step run and 2. Keep the markdown results clear (striping of ansi codes)

hth

thekad · 2023-12-19T23:36:28Z

I can answer about this one 😸
2. the output is exactly the same as the previous output, but you're making it harder by forcing color output then striping the colors out of it, what exactly are you trying to accomplish here?
The output is different as it includes coloring in the step when ansible-lint is running, here: https://github.com/redhatci/ansible-collection-redhatci-ocp/actions/runs/7268748379/job/19805160605?pr=102#step:6:162 vs https://github.com/redhatci/ansible-collection-redhatci-ocp/actions/runs/7267875512/job/19802603666#step:6:44

The end result is, 1. Visually better output in the detailed step run and 2. Keep the markdown results clear (striping of ansi codes)

hth

I see, you want the colors to be displayed since it's changing a > for a | tee and they would be pretty printed in the detail view. I still say that accomplishes the same thing at the end when building the summary because you strip the coloring codes anyway, but I get it.

tonyskapunk · 2023-12-19T23:37:19Z

I'm removing the test commit added, since it was just for demo/test purpose 😺 here the link to the summary: https://github.com/redhatci/ansible-collection-redhatci-ocp/actions/runs/7268748379#summary-19805160605

tonyskapunk · 2023-12-19T23:41:07Z

I see, you want the colors to be displayed since it's changing a > for a | tee and they would be pretty printed in the detail view.

I'm assuming the same 😄 I'm reviewing the change and providing a fix to make sure the ansi code does not get into the markdown for the summary.

I still say that accomplishes the same thing at the end when building the summary because you strip the coloring codes anyway, but I get it.

I think the main difference is that the coloring in the step details helps for reading, the summary is well, a summary only :)

softwarefactory-project-zuul · 2023-12-19T23:41:15Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0e9c4252d3274054817fcebead80dc01

✔️ dci-rpm-build-el8 SUCCESS in 3m 39s
✔️ dci-rpm-build-el9 SUCCESS in 3m 17s

tonyskapunk

LGTM, although I'd like someone else to review due to the changes I've introduced 😅

dcibot · 2023-12-20T01:24:36Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/4e77f470-c785-4c4b-bf0b-78f3553a12d2/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/de0d58c8-d421-430d-9daf-51338141fd48/jobStates

fredericlepied · 2023-12-20T06:26:09Z

your PR title says fix the sanity check, but you're changing the ansible-lint check

Agreed. Fixing the commit the message. It was too late yesterday ;-)

2. the output is exactly the same as the previous output, but you're making it harder by forcing color output then striping the colors out of it, what exactly are you trying to accomplish here?

It is not the same as we do see the actual reports in the detail view if someone wants to fix them else we don't see anything. I did it like this to be consistent the Sanity test job.

softwarefactory-project-zuul · 2023-12-20T06:38:26Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4aef9a4d46e449a2989e49ebd1e8d94e

✔️ dci-rpm-build-el8 SUCCESS in 3m 22s
✔️ dci-rpm-build-el9 SUCCESS in 3m 09s

.github/workflows/pr.yml

softwarefactory-project-zuul · 2023-12-20T15:21:42Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4a12d4eb0ce9467ca804491340428b3c

✔️ dci-rpm-build-el8 SUCCESS in 3m 54s
✔️ dci-rpm-build-el9 SUCCESS in 4m 05s

.github/workflows/pr.yml

softwarefactory-project-zuul · 2023-12-20T19:15:01Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b1704d6ca0c24eeca4a811fb20313a75

✔️ dci-rpm-build-el8 SUCCESS in 3m 44s
✔️ dci-rpm-build-el9 SUCCESS in 4m 34s

softwarefactory-project-zuul · 2023-12-22T11:19:11Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/259b57ed64bb4e00ab30a8d6f45a9f64

✔️ dci-rpm-build-el8 SUCCESS in 3m 26s
✔️ dci-rpm-build-el9 SUCCESS in 2m 56s

softwarefactory-project-zuul · 2023-12-22T23:22:25Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/53bb4b60755848ffab0ced2ce4eaa182

✔️ dci-rpm-build-el8 SUCCESS in 3m 31s
✔️ dci-rpm-build-el9 SUCCESS in 3m 14s

softwarefactory-project-zuul · 2024-01-02T14:59:17Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/f4b77d9a87ed459094225b0eeb4c1013

❌ dci-rpm-build-el8 FAILURE in 1m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 55s

thekad · 2024-01-02T18:27:14Z

@fredericlepied can you rebase? that will trigger a rebuild anyway, seems like it was a temporary error

softwarefactory-project-zuul · 2024-01-02T18:44:36Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/375173b01c4a431eb2b3e21250ed95f3

❌ dci-rpm-build-el8 MERGE_CONFLICT in 0s
✔️ dci-rpm-build-el9 SUCCESS in 3m 36s

softwarefactory-project-zuul · 2024-01-03T08:49:04Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/baef4ea6df5b42e68c533d794cfa0682

✔️ dci-rpm-build-el8 SUCCESS in 3m 36s
✔️ dci-rpm-build-el9 SUCCESS in 3m 21s

softwarefactory-project-zuul · 2024-01-03T09:30:09Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/16bfaba696c74484afdbfb6a0394f153

✔️ dci-rpm-build-el8 SUCCESS in 3m 36s
❌ dci-rpm-build-el9 FAILURE in 1m 06s

- sanity: capture the output for all the versions of Python for the summary - ansible-lint: display the output of ansible-lint on the PR in the job detail view - ansible-lint: use colors like in Sanity Check - check-all-dependencies-are-merged: do not checkout the code

Removes the ansi code before adding it to the GH step summary for a propoer reading

softwarefactory-project-zuul · 2024-01-03T17:36:46Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/79a455a1c0bf4530b654f0a0bdb05358

✔️ dci-rpm-build-el8 SUCCESS in 3m 40s
✔️ dci-rpm-build-el9 SUCCESS in 3m 15s

fredericlepied requested a review from a team as a code owner December 19, 2023 21:56

fredericlepied mentioned this pull request Dec 19, 2023

Limit sanity checks by Python 3.6+ #101

Merged

fredericlepied force-pushed the fix-output branch from 432b038 to 0969bdd Compare December 19, 2023 21:58

fredericlepied force-pushed the fix-output branch 2 times, most recently from ce4cf41 to d0df895 Compare December 19, 2023 22:06

tonyskapunk reviewed Dec 19, 2023

View reviewed changes

.github/workflows/pr.yml Show resolved Hide resolved

fredericlepied requested a review from a team as a code owner December 19, 2023 23:22

tonyskapunk force-pushed the fix-output branch from 4ff6b29 to 3cdec7e Compare December 19, 2023 23:37

tonyskapunk previously approved these changes Dec 19, 2023

View reviewed changes

fredericlepied dismissed tonyskapunk’s stale review via 90f0d63 December 20, 2023 06:34

fredericlepied force-pushed the fix-output branch from 3cdec7e to 90f0d63 Compare December 20, 2023 06:34

fredericlepied changed the title ~~fix Sanity test output capture~~ CI: output fixes Dec 20, 2023

thekad reviewed Dec 20, 2023

View reviewed changes

.github/workflows/pr.yml Outdated Show resolved Hide resolved

.github/workflows/pr.yml Outdated Show resolved Hide resolved

.github/workflows/pr.yml Outdated Show resolved Hide resolved

fredericlepied force-pushed the fix-output branch from 90f0d63 to b237a66 Compare December 20, 2023 15:17

thekad reviewed Dec 20, 2023

View reviewed changes

.github/workflows/pr.yml Show resolved Hide resolved

fredericlepied force-pushed the fix-output branch from b237a66 to 9badcbc Compare December 20, 2023 19:10

fredericlepied force-pushed the fix-output branch from 9badcbc to 45c5e69 Compare December 22, 2023 11:15

fredericlepied force-pushed the fix-output branch from 45c5e69 to 6281407 Compare December 22, 2023 23:18

fredericlepied force-pushed the fix-output branch from 6281407 to 947fd30 Compare January 2, 2024 14:56

fredericlepied force-pushed the fix-output branch from 947fd30 to 5b6454a Compare January 2, 2024 18:40

fredericlepied force-pushed the fix-output branch from 5b6454a to c736632 Compare January 3, 2024 08:45

fredericlepied force-pushed the fix-output branch from c736632 to 537c722 Compare January 3, 2024 09:26

fredericlepied and others added 2 commits January 3, 2024 18:32

CI: output fixes

8166a95

- sanity: capture the output for all the versions of Python for the summary - ansible-lint: display the output of ansible-lint on the PR in the job detail view - ansible-lint: use colors like in Sanity Check - check-all-dependencies-are-merged: do not checkout the code

Filter ANSI color codes from ansible-lint output

646540a

Removes the ansi code before adding it to the GH step summary for a propoer reading

fredericlepied force-pushed the fix-output branch from 537c722 to 646540a Compare January 3, 2024 17:32

thekad approved these changes Jan 3, 2024

View reviewed changes

fredericlepied merged commit 8172b85 into main Jan 3, 2024
5 checks passed

fredericlepied deleted the fix-output branch January 3, 2024 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: output fixes #102

CI: output fixes #102

fredericlepied commented Dec 19, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

dcibot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

thekad commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

thekad commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

tonyskapunk left a comment

dcibot commented Dec 20, 2023

fredericlepied commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 22, 2023

softwarefactory-project-zuul bot commented Dec 22, 2023

softwarefactory-project-zuul bot commented Jan 2, 2024

thekad commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

CI: output fixes #102

CI: output fixes #102

Conversation

fredericlepied commented Dec 19, 2023 • edited Loading

softwarefactory-project-zuul bot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

dcibot commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

thekad commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

thekad commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

tonyskapunk commented Dec 19, 2023

softwarefactory-project-zuul bot commented Dec 19, 2023

tonyskapunk left a comment

Choose a reason for hiding this comment

dcibot commented Dec 20, 2023

fredericlepied commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 20, 2023

softwarefactory-project-zuul bot commented Dec 22, 2023

softwarefactory-project-zuul bot commented Dec 22, 2023

softwarefactory-project-zuul bot commented Jan 2, 2024

thekad commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

softwarefactory-project-zuul bot commented Jan 3, 2024

fredericlepied commented Dec 19, 2023 •

edited

Loading