Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin relies on /etc/redhat_access/config.yml #20

Open
ares opened this issue Apr 5, 2018 · 4 comments
Open

The plugin relies on /etc/redhat_access/config.yml #20

ares opened this issue Apr 5, 2018 · 4 comments

Comments

@ares
Copy link
Collaborator

ares commented Apr 5, 2018

Other Foreman plugins use /etc/foreman/settings.d/redhat_access.yml, it might be good to unify this

@ares
Copy link
Collaborator Author

ares commented Apr 11, 2018

Also it would be good to provide better error message in case the file does not exist. Now it fails with

NameError: uninitialized constant RedhatAccess::Api::LogsController::REDHAT_ACCESS_CONFIG

and cryptic trace

@lphiri
Copy link
Contributor

lphiri commented Apr 11, 2018

@ares are you seeing this error during build?

@ares
Copy link
Collaborator Author

ares commented Apr 11, 2018

yes

EDIT: which should be fixed easily by cp in %build but in geneneral, I was pretty confused by the same error when I installed devel setup. I think we should catch that exception or simply add a check and print nicer error message

@lphiri
Copy link
Contributor

lphiri commented Apr 11, 2018

I have added a default config file that should help with the config build error:
e93891a

Keeping the issue open to address moving the config to settings.d directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants