Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: is_scaleup always return 0 due to -o pipefail #386

Open
ioggstream opened this issue Aug 30, 2017 · 0 comments
Open

bug: is_scaleup always return 0 due to -o pipefail #386

ioggstream opened this issue Aug 30, 2017 · 0 comments

Comments

@ioggstream
Copy link
Contributor

I expect

is_scaleup to return EXIT_SUCCESS (0) only if there are new nodes

instead

returns EXIT_SUCCESS whenever ansible/inventory and ansible.deployed/inventory differs

Hint

This is due to

set -o pipefail

which causes every diff to return EXIT_FAILURE
@ioggstream ioggstream changed the title bug: is_scaleup only work on first run bug: is_scaleup always return 0 due to -o pipefail Aug 30, 2017
ioggstream added a commit to ioggstream/openshift-on-openstack that referenced this issue Aug 30, 2017
@ioggstream
fix: is_scaleup always return 0 redhat-openstack#386
25e123c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ioggstream