Introduce ability to get profile data #1215
Conversation
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
from change #1215: |
| defer f.Close() | ||
|
|
||
| if err := pprof.StartCPUProfile(f); err != nil { | ||
| logger.Error(err, "could not start CPU profile") |
There was a problem hiding this comment.
should this error be returned?
There was a problem hiding this comment.
Sure. I'll add that.
| if viper.Instance().IsSet("memprofile") { | ||
| f, err := os.Create(viper.Instance().GetString("memprofile")) | ||
| if err != nil { | ||
| logger.Error(err, "could not create memory profile") |
There was a problem hiding this comment.
Should this error be returned?
|
|
||
| rt.GC() // get up-to-date statistics | ||
| if err := pprof.Lookup("allocs").WriteTo(f, 0); err != nil { | ||
| logger.Error(err, "could not start memory profile") |
There was a problem hiding this comment.
Should this error be returned?
It was where I knew we were looking for a data from. If we decide we need it elsewhere in the future, we can cross that bridge then. |
This exposes two environment variables, PFLT_MEMPROFILE and PFLT_CPUPROFILE, that should be set to the path and name of a file to write the profile data to. These can then be processed with `go tool pprof` for further analysis. Signed-off-by: Brad P. Crochet <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
from change #1215: |
This exposes two environment variables, PFLT_MEMPROFILE and PFLT_CPUPROFILE, that should be set to the path and name of a file to write the profile data to. These can then be processed with
go tool pproffor further analysis.