Improve handling of un-indented arrays #989
Open
+74
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given steps: - task: PowerShell@2 | We should be completing properties for the object that `task` is a part of, not the list under `steps`. Previously, the parent algorithm would see that the current indentation == the configured indentation and incorrectly choose the parent list as the "real" closest node, despite the cursor clearly being more indented than the list. Now, we also verify that the indentation of the current node equals the cursor indentation before deciding to look at the parent.
Given steps: - task: PowerShell@2 | We can either complete schemas that are siblings of `steps` or continue adding onto the array, but what we _cannot_ do is suggest array items without the leading array indicator. In essence, this reverts redhat-developer#804 as my previous commit addresses that in a different way.
winstliu
changed the title
winstliu
added a commit
to microsoft/azure-pipelines-language-server
that referenced
this pull request
Nov 1, 2024
Contributed to upstream as redhat-developer/yaml-language-server#989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves handling of un-indented arrays by fixing two similar scenarios.
Scenario 1
Given
We should be completing properties for the object that
taskis a part of, not the list understeps.Previously, the parent algorithm would see that the current indentation == the configured indentation and incorrectly choose the parent list as the "real" closest node, despite the cursor clearly being more indented than the list.
Now, we also verify that the indentation of the current node equals the cursor indentation before deciding to look at the parent.
Scenario 2
Given
It is less clear if we want to continue adding onto the array, or if we want to complete schemas that are siblings of
steps.What we do know, however, is that we cannot suggest array items without the leading array indicator. #804 added that incorrect behavior while trying to fix a subset of Scenario 1. Now with Scenario 1 fixed, #804 can be reverted which also fixes Scenario 2.
What issues does this PR fix or reference?
N/A, I caught both of these issues when trying to catch azure-pipelines-language-server back up with yaml-language-server.
Is it tested? How?
Added unit tests and confirmed that all tests pass.