Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- array item suggestion gives extra line #930

Closed
1 of 4 tasks
p-spacek opened this issue Oct 11, 2023 · 1 comment
Closed
1 of 4 tasks

- array item suggestion gives extra line #930

p-spacek opened this issue Oct 11, 2023 · 1 comment

Comments

@p-spacek
Copy link
Contributor

Describe the bug

after applying PR #901 (- (array item) suggestion was missing for some specific situations, for example: enums.)

the inserted text - (array item) includes also a new line symbol
the problem was there before that PR, but it's possible to reproduce it by the test case mentioned inside the PR:

https://user-images.githubusercontent.com/38421337/252634068-a856895b-f708-4dc9-917f-7b97a7b9988b.png

{
          type: 'object',
          properties: {
            references: {
              type: 'array',
              items: {
                enum: ['item1', 'item2']
              }
           }
      }
 }

Expected Behavior

the yaml after insert should looks like

stories:
  - item1
  - 

so no extra new line

Current Behavior

stories:
  - item1
  -
  # extra line

Environment

probably all

  • Windows
  • Mac
  • Linux
  • other (please specify)
@p-spacek
Copy link
Contributor Author

closing this, it's not worth bothering with it, I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant