Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cello" example suggests removing %configure macro at all #75

Open
jccleaver opened this issue Aug 24, 2019 · 0 comments
Open

"cello" example suggests removing %configure macro at all #75

jccleaver opened this issue Aug 24, 2019 · 0 comments

Comments

@jccleaver
Copy link

In https://github.com/redhat-developer/rpm-packaging-guide/blob/master/source/packaging-software.adoc it is written:

However, we need to remove the call to %configure because we did not provide a ifdef::rhel[configure script].

This would seem to be bad advice at any point. The %configure macro will place $CFLAGS, etc into the environment to be used by the follow-up 'make' command; not using it may not output a correct build for the distro. A better option (while also tutorializing how to get around certain issues caused by upstream) might be:

%build
# source has no configure script; use macro anyway
echo "#!/bin/sh" > configure ; chmod +x configure

%configure
make %{?_smp_mflags}

For current RPM releases, one could also use this instead of making a dummy file:

%define _configure /bin/true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant