Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirecting to Podman Desktop requires prompt #92

Open
vrothberg opened this issue Apr 3, 2024 · 6 comments
Open

redirecting to Podman Desktop requires prompt #92

vrothberg opened this issue Apr 3, 2024 · 6 comments
Assignees
Labels
kind/enhancement ✨ New feature or request

Comments

@vrothberg
Copy link
Collaborator

Any chance we can get rid of the prompt below? It's adding one click and gets in the user's way.

Cc: @benoitf @dgolovin @slemeur

Screenshot 2024-04-03 at 09 02 47

@benoitf
Copy link
Collaborator

benoitf commented Apr 3, 2024

we can't it's the browser that triggers that

@benoitf
Copy link
Collaborator

benoitf commented Apr 8, 2024

so, here, I think the key would be to not use the podman-desktop URI (dead end as it's managed by the Browser)

But, as we're browsing the content of the page provided by the extension and if we're here it's because Podman Desktop is already running

so the pattern should be:

if I click on a button, notify backend side of the extension that I need to go back to Podman Desktop

then, the extension should call something to Podman Desktop core to bring back the window (focus / steal)

I think the issue can be reopened but the flow needs to be changed (as the way it is currently implemented it won't be possible)

@benoitf benoitf reopened this Apr 8, 2024
@benoitf
Copy link
Collaborator

benoitf commented Apr 8, 2024

@vrothberg I'm confused, you closed the issue but it means we still have that popup while we could improve it not have it.

@vrothberg vrothberg reopened this Apr 8, 2024
@vrothberg
Copy link
Collaborator Author

Apologies! I must have missed that you reopened and just clicked on the button without reading.

@benoitf
Copy link
Collaborator

benoitf commented Apr 8, 2024

no problem, just wanted to confirm

@dgolovin
Copy link
Collaborator

dgolovin commented Jul 5, 2024

Implementation ideas for activating PD window electron/electron#2867

@dgolovin dgolovin added the kind/enhancement ✨ New feature or request label Sep 11, 2024
@dgolovin dgolovin self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants