From df7b2a2905c85aa28279c8eab63ad8c86ff5229b Mon Sep 17 00:00:00 2001 From: Akira Yokochi Date: Tue, 3 Dec 2024 20:34:45 +0900 Subject: [PATCH 1/3] fix default value *_credentials_secure_logging in README --- roles/controller_credentials/README.md | 2 +- roles/eda_credentials/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/controller_credentials/README.md b/roles/controller_credentials/README.md index c46ba4d18..653428a1c 100644 --- a/roles/controller_credentials/README.md +++ b/roles/controller_credentials/README.md @@ -38,7 +38,7 @@ Enabling this will enforce configurtion without specifying every option in the c |Variable Name|Default Value|Required|Description| |:---:|:---:|:---:|:---:| -|`controller_configuration_credentials_enforce_defaults`|`false`|no|Whether or not to enforce default option values on only the applications role| +|`controller_configuration_credentials_enforce_defaults`|`true`|no|Whether or not to enforce default option values on only the applications role| |`aap_configuration_enforce_defaults`|`false`|no|This variable enables enforced default values as well, but is shared across multiple roles, see above.| ### Secure Logging Variables diff --git a/roles/eda_credentials/README.md b/roles/eda_credentials/README.md index ecec4f2a1..c8a458fe7 100644 --- a/roles/eda_credentials/README.md +++ b/roles/eda_credentials/README.md @@ -26,7 +26,7 @@ eda_configuration_credentials_secure_logging defaults to the value of aap_config |Variable Name|Default Value|Required|Description| |:---:|:---:|:---:|:---:| -|`eda_configuration_credentials_secure_logging`|`false`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.| +|`eda_configuration_credentials_secure_logging`|`true`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.| |`aap_configuration_secure_logging`|`false`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.| ### Asynchronous Retry Variables From 4e0bacacf25f5fab569648d76a4bf44b55a3fffd Mon Sep 17 00:00:00 2001 From: Akira Yokochi Date: Wed, 4 Dec 2024 09:00:17 +0900 Subject: [PATCH 2/3] manual revert controller_configuration_credentials_enforce_defaults default value --- roles/controller_credentials/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/controller_credentials/README.md b/roles/controller_credentials/README.md index 653428a1c..c46ba4d18 100644 --- a/roles/controller_credentials/README.md +++ b/roles/controller_credentials/README.md @@ -38,7 +38,7 @@ Enabling this will enforce configurtion without specifying every option in the c |Variable Name|Default Value|Required|Description| |:---:|:---:|:---:|:---:| -|`controller_configuration_credentials_enforce_defaults`|`true`|no|Whether or not to enforce default option values on only the applications role| +|`controller_configuration_credentials_enforce_defaults`|`false`|no|Whether or not to enforce default option values on only the applications role| |`aap_configuration_enforce_defaults`|`false`|no|This variable enables enforced default values as well, but is shared across multiple roles, see above.| ### Secure Logging Variables From 74dd39208504fd5310fcd95a7b8a147527ed7716 Mon Sep 17 00:00:00 2001 From: Akira Yokochi Date: Wed, 4 Dec 2024 09:00:57 +0900 Subject: [PATCH 3/3] fix default value controller_configuration_credentials_secure_logging in README --- roles/controller_credentials/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/controller_credentials/README.md b/roles/controller_credentials/README.md index c46ba4d18..466a8338a 100644 --- a/roles/controller_credentials/README.md +++ b/roles/controller_credentials/README.md @@ -50,7 +50,7 @@ controller_configuration_credentials_secure_logging defaults to the value of aap |Variable Name|Default Value|Required|Description| |:---:|:---:|:---:|:---:| -|`controller_configuration_credentials_secure_logging`|`false`|no|Whether or not to include the sensitive Credential role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.| +|`controller_configuration_credentials_secure_logging`|`true`|no|Whether or not to include the sensitive Credential role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.| |`aap_configuration_secure_logging`|`false`|no|This variable enables secure logging as well, but is shared across multiple roles, see above.| ### Asynchronous Retry Variables