Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_mode testing #828

Open
Tompage1994 opened this issue May 13, 2024 · 2 comments
Open

Add check_mode testing #828

Tompage1994 opened this issue May 13, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Tompage1994
Copy link
Collaborator

The role supports using check_mode. We should add some tests to ensure this is working properly and not being regressed like found in #815

              I agree this is a good change. I can see how we haven't spotted it before as well. I think we should add some check_mode testing to the tests to prove this out. If you fancy doing that, then great, otherwise I can raise an issue to fix that afterwards.

Originally posted by @Tompage1994 in #815 (review)

@github-actions github-actions bot added the inactive No movement has happened in 30 days label Jun 13, 2024
@djdanielsson djdanielsson added help wanted Extra attention is needed and removed inactive No movement has happened in 30 days labels Jun 14, 2024
@w4hf
Copy link
Contributor

w4hf commented Jul 28, 2024

Not sure if this is the right place to post this but I'm getting the error "msg": "check mode and async cannot be used on same task." when running in check mode.
Tested on ansible 2.15.0 with the role's role. Failed on task Managing Role Based Access Entries on Controller
Maybe we should have seperate check tasks ?

@MallocArray
Copy link
Contributor

I believe this has been addressed at this point, as there are async tasks that are not executed if running in check_mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants