From 1548d62f0841bb390533adbb2c25de4c9270b6cf Mon Sep 17 00:00:00 2001
From: Avi Biton <abiton@redhat.com>
Date: Thu, 14 Dec 2023 19:05:17 +0200
Subject: [PATCH] chore(RHTAPWATCH-641): collect usigned RPMs

implement the get_unsigned_rpms method
add unit tests

Signed-off-by: Avi Biton <abiton@redhat.com>
---
 tests/test_rpm_verifier.py  | 43 ++++++++++++++++++++++++++++++++++---
 verify_rpms/rpm_verifier.py | 27 +++++++++++++++++++++--
 2 files changed, 65 insertions(+), 5 deletions(-)

diff --git a/tests/test_rpm_verifier.py b/tests/test_rpm_verifier.py
index 0ee64fe..55bd0d1 100644
--- a/tests/test_rpm_verifier.py
+++ b/tests/test_rpm_verifier.py
@@ -13,6 +13,7 @@
     ProcessedImage,
     generate_output,
     get_rpmdb,
+    get_unsigned_rpms,
 )
 
 
@@ -93,21 +94,57 @@ def test_generate_output(
     assert print_out == expected_print
 
 
+@pytest.mark.parametrize(
+    "test_input,expected",
+    [
+        pytest.param(
+            dedent(
+                """
+                libssh-config-0.9.6-10.el8_8 (none) RSA/SHA256, Tue 6 May , Key ID 1234567890
+                python39-twisted-23.10.0-1.el8ap (none) (none)
+                libmodulemd-2.13.0-1.el8 (none) RSA/SHA256, Wed 18 Aug , Key ID 1234567890
+                gpg-pubkey-d4082792-5b32db75 (none) (none)
+                """
+            ).strip(),
+            ["python39-twisted-23.10.0-1.el8ap"],
+            id="Mix of signed and unsigned",
+        ),
+        pytest.param(
+            dedent(
+                """
+                libssh-config-0.9.6-10.el8_8 (none) RSA/SHA256, Tue 6 May , Key ID 1234567890
+                libmodulemd-2.13.0-1.el8 (none) RSA/SHA256, Wed 18 Aug , Key ID 1234567890
+                """
+            ).strip(),
+            [],
+            id="All signed",
+        ),
+        pytest.param("", [], id="Empty list"),
+    ],
+)
+def test_get_unsigned_rpms(test_input: list[str], expected: list[str]) -> None:
+    """Test get_unsigned_rpms"""
+    mock_runner = MagicMock()
+    mock_runner.return_value.stdout = test_input
+    result = get_unsigned_rpms(rpmdb=Path("rpmdb_folder"), runner=mock_runner)
+    assert result == expected
+
+
 class TestImageProcessor:
     """Test ImageProcessor's callable"""
 
     @pytest.fixture()
     def mock_db_getter(self) -> MagicMock:
-        "mocked db_getter function"
+        """mocked db_getter function"""
         return MagicMock()
 
     @pytest.fixture()
     def mock_rpms_getter(self) -> MagicMock:
-        "mocked rpms_getter function"
+        """mocked rpms_getter function"""
         return MagicMock()
 
     @pytest.mark.parametrize(
-        ("unsigned_rpms"),
+        ("unsigned_rpms",),
         [
             pytest.param([], id="all signed"),
             pytest.param(["my-unsigned-rpm"], id="one unsigned"),
diff --git a/verify_rpms/rpm_verifier.py b/verify_rpms/rpm_verifier.py
index 5264a17..42249b0 100644
--- a/verify_rpms/rpm_verifier.py
+++ b/verify_rpms/rpm_verifier.py
@@ -43,8 +43,31 @@ def get_rpmdb(container_image: str, target_dir: Path, runner: Callable = run) ->
 
 
 def get_unsigned_rpms(rpmdb: Path, runner: Callable = run) -> list[str]:
-    """Get unsigned RPMs from RPM DB path"""
-    raise NotImplementedError()
+    """
+    Get all unsigned RPMs from RPM DB path
+    Filter and return the unsigned RPMs
+    :param rpmdb: path to RPM DB folder
+    :param runner: subprocess.run to run CLI commands
+    :return: list of unsigned RPMs within the folder
+    """
+    rpm_strs = runner(
+        [
+            "rpm",
+            "-qa",
+            "--qf",
+            "%{NAME}-%{VERSION}-%{RELEASE} %{SIGGPG:pgpsig} %{SIGPGP:pgpsig}\n",
+            "--dbpath",
+            str(rpmdb),
+        ],
+        capture_output=True,
+        text=True,
+        check=True,
+    ).stdout.splitlines()
+    return [
+        rpm.split()[0]
+        for rpm in rpm_strs
+        if "Key ID" not in rpm and not rpm.startswith("gpg-pubkey")
+    ]
 
 
 def generate_output(