Bug 2308144: Correct ConfigMap creation logic and update unit tests #231
Conversation
- Updated the `createOrUpdateConfigMap` function to handle nested data structures correctly, ensuring that YAML content is properly extracted and parsed. - Adjusted the logic to filter for YAML keys in the ManagedClusterView data and marshal the parsed data into JSON for storage in the ConfigMap. - Ensured that the `Controller` field in the OwnerReferences is set to `false` where necessary to prevent conflicts. - Modified unit tests to reflect the changes in the data structure and logic, ensuring accurate validation of the ConfigMap content and OwnerReferences. - Fixed a bug where the `Scope` check in the `hasODFInfoInScope` function was incorrectly using `Kind` instead of `Resource`. Signed-off-by: vbadrina <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vbnrh
changed the title
|
@vbnrh: This pull request references Bugzilla bug 2308144, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test integration-test |
openshift-merge-bot
bot
merged commit 771f93d
into
red-hat-storage:main
|
/cherry-pick release-4.17 |
|
@vbnrh: new pull request created: #233 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
createOrUpdateConfigMapfunction to handle nested data structures correctly, ensuring that YAML content is properly extracted and parsed.Controllerfield in the OwnerReferences is set tofalsewhere necessary to prevent conflicts.Scopecheck in thehasODFInfoInScopefunction was incorrectly usingKindinstead ofResource.