Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runbooks_url to alerts #2316

Merged
merged 1 commit into from
Dec 12, 2023
Merged

add runbooks_url to alerts #2316

merged 1 commit into from
Dec 12, 2023

Conversation

weirdwiz
Copy link
Contributor

this commit adds runbook_urls to further alerts in ceph and ODF

@weirdwiz
Copy link
Contributor Author

ptal @umangachapagain @jmolmo

jmolmo
jmolmo suggested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember.. for the "mixin" alerts:

Generate deployment manifests by using the OCS-operator Makefile target gen-latest-prometheus-rules-yamls : make gen-latest-prometheus-rules-yamls. The generated manifests will be written at metrics/deploy/prometheus-ocs-rules.yaml(Internal mode) and metrics/deploy/prometheus-ocs-rules-external.yaml(External mode)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@weirdwiz weirdwiz force-pushed the runbooks_url branch 2 times, most recently from 04df279 to b17c93b Compare December 12, 2023 09:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@weirdwiz weirdwiz force-pushed the runbooks_url branch 2 times, most recently from 4e1b69d to 0be9767 Compare December 12, 2023 09:33
@weirdwiz
add runbooks_url to alerts
60c4631 
this commit adds runbook_urls to further alerts in ceph and ODf

Signed-off-by: Divyansh Kamboj <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmolmo, umangachapagain, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 6a31e91 into red-hat-storage:main Dec 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

@jmolmo jmolmo jmolmo approved these changes

Assignees

@jmolmo jmolmo

@umangachapagain umangachapagain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weirdwiz @jmolmo @umangachapagain @openshift-merge-robot