vm snapshot test case #11045
vm snapshot test case #11045
Conversation
Signed-off-by: Parikshith <[email protected]>
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cnv3
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv/test_vm_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_ops
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Parikshith <[email protected]>
pull-request-size
bot
added
size/L
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cnv3
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv/test_vm_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_ops
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Signed-off-by: Parikshith <[email protected]>
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cnv3
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_ops
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Parikshith <[email protected]>
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cnv3
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_ops
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
| # Write new file to VM | ||
| run_dd_io(vm_obj=res_vm_obj, file_path=file_paths[1], verify=True) |
There was a problem hiding this comment.
this should be done after validating the data integrity
There was a problem hiding this comment.
Sure I am working on this and it will take care in my next PR
| res_csum = cal_md5sum_vm(vm_obj=res_vm_obj, file_path=file_paths[0]) | ||
| assert ( | ||
| source_csum == res_csum | ||
| ), f"Failed: MD5 comparison between source {vm_obj.name} and cloned {res_vm_obj.name} VMs" |
There was a problem hiding this comment.
the operation is restore not clone, please update the assert message accordingly
There was a problem hiding this comment.
Sure I am working on this and it will take care in my next PR
| assert ( | ||
| source_csum == res_csum | ||
| ), f"Failed: MD5 comparison between source {vm_obj.name} and cloned {res_vm_obj.name} VMs" | ||
| res_vm_obj.stop() |
There was a problem hiding this comment.
step 7 says "Delete all the VMs created as part of this test", here we are only stopping the VM, not deleting it
There was a problem hiding this comment.
Sure I am working on this and it will take care in my next PR
| res_snap_obj = snapshot_restore_factory( | ||
| snapshot_obj=snap_obj, | ||
| storageclass=vm_obj.sc_name, | ||
| size=vm_obj.pvc_size, |
There was a problem hiding this comment.
Ideally, the pvc size will be same as the restore size of snapshot. This is not a must and can be removed
There was a problem hiding this comment.
Sure I am working on this and it will take care in my next PR
| @@ -7088,7 +7091,8 @@ def teardown(): | |||
| Cleans up the CNV workloads | |||
|
|
|||
| """ | |||
| for cnv_wl in cnv_workloads: | |||
| # Iterating from end so that restored VMs are deleted before source | |||
There was a problem hiding this comment.
Is deleting the restored VMs before the source causing any problems? At least in PVCs, IIRC, I don't think there will be any issues. The parent PVC can be deleted even with the restored PVC in use
There was a problem hiding this comment.
Sure I am working on this and I will take care of this in my next immediate PR.
There was a problem hiding this comment.
Based on avadhoot's comments, I will merge this PR as it's required urgently and low priority review comments will be handled in a followup PR
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avd-sagare, hnallurv, parikshithb, shylesh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.