From d74b2df456b23751f3571497dfcf7637d82dbb4e Mon Sep 17 00:00:00 2001 From: dahorak Date: Tue, 17 Oct 2023 17:53:34 +0200 Subject: [PATCH] fix test_failure_propagator (#8688) * fix test_failure_propagator - set default skipped_on_ceph_health_threshold to 0 - update rounding of skipped_on_ceph_health_ratio to 3 digits - update README Signed-off-by: Daniel Horak --- conf/README.md | 4 ++-- ocs_ci/framework/conf/default_config.yaml | 2 +- tests/test_failure_propagator.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/README.md b/conf/README.md index 1236fefec6d..3400b288456 100644 --- a/conf/README.md +++ b/conf/README.md @@ -64,8 +64,8 @@ run it belongs here. * `skipped_on_ceph_health_ratio` - The ratio of tests skipped due to Ceph unhealthy against the number of tests being collected for the test execution * `skipped_on_ceph_health_threshold` - The allowed threshold for the ratio of tests skipped due to Ceph unhealthy against the - number of tests being collected for the test execution. The default value is set to 0.1 (10%). - For acceptance suite, the value would be set to 0 + number of tests being collected for the test execution. The default value is set to 0. + For acceptance suite, the value would be always overwritten to 0. #### DEPLOYMENT diff --git a/ocs_ci/framework/conf/default_config.yaml b/ocs_ci/framework/conf/default_config.yaml index 19537eafbf0..7555c049eaa 100644 --- a/ocs_ci/framework/conf/default_config.yaml +++ b/ocs_ci/framework/conf/default_config.yaml @@ -37,7 +37,7 @@ RUN: skipped_tests_ceph_health: 0 number_of_tests: None skipped_on_ceph_health_ratio: 0 - skipped_on_ceph_health_threshold: 0.1 + skipped_on_ceph_health_threshold: 0 # In this section we are storing all deployment related configuration but not diff --git a/tests/test_failure_propagator.py b/tests/test_failure_propagator.py index 3698bba3067..983043cb44f 100644 --- a/tests/test_failure_propagator.py +++ b/tests/test_failure_propagator.py @@ -78,7 +78,7 @@ def test_report_skip_triggering_test(self, request): config.RUN.get("skipped_tests_ceph_health") / number_of_eligible_tests ), - 1, + 3, ) log.info( f"skipped_on_ceph_health_ratio: {config.RUN.get('skipped_on_ceph_health_ratio')}"