From c6efea401c41567720fbc17a9566bcd3170823d8 Mon Sep 17 00:00:00 2001 From: vavuthu Date: Wed, 16 Oct 2024 16:51:02 +0530 Subject: [PATCH] remove Rotational duplicate in LocalVolumeSet Signed-off-by: vavuthu --- ocs_ci/deployment/helpers/lso_helpers.py | 6 ++++-- ocs_ci/templates/ocs-deployment/local-volume-set.yaml | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ocs_ci/deployment/helpers/lso_helpers.py b/ocs_ci/deployment/helpers/lso_helpers.py index 5aa08e0bffb..1f389a1e001 100644 --- a/ocs_ci/deployment/helpers/lso_helpers.py +++ b/ocs_ci/deployment/helpers/lso_helpers.py @@ -145,8 +145,10 @@ def setup_local_storage(storageclass): # Since we don't have datastore with SSD on our current VMware machines, localvolumeset doesn't detect # NonRotational disk. As a workaround we are setting Rotational to device MechanicalProperties to detect # HDD disk - if platform == constants.VSPHERE_PLATFORM or config.ENV_DATA.get( - "local_storage_allow_rotational_disks" + if ( + platform == constants.VSPHERE_PLATFORM + or config.ENV_DATA.get("local_storage_allow_rotational_disks") + or config.ENV_DATA.get("odf_provider_mode_deployment") ): logger.info( "Adding Rotational for deviceMechanicalProperties spec" diff --git a/ocs_ci/templates/ocs-deployment/local-volume-set.yaml b/ocs_ci/templates/ocs-deployment/local-volume-set.yaml index 7295076dd94..2b18a42297d 100644 --- a/ocs_ci/templates/ocs-deployment/local-volume-set.yaml +++ b/ocs_ci/templates/ocs-deployment/local-volume-set.yaml @@ -6,7 +6,6 @@ metadata: spec: deviceInclusionSpec: deviceMechanicalProperties: - - Rotational - NonRotational deviceTypes: - disk