Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-943] Feature/template filter #270

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented May 10, 2024

SDK-943

Description

  • current release gets all templates and they don't match well together, it also bloats the templates panel a bit making it take longer
    image
    this PR includes the ability to filter these, it still requests all of them (because the endpoint param doesn't work) but then filters before downloading all the renders.
  • it's now exposed in the TemplateSelectionElement
    image
    I also renamed the options to be V1, V2 because I feel like the naming on the backend is not really relevant to the use ("onboarding", "randomize"). "Onboarding" type are the new ones so I named them V2.

How to Test

  • open elements creator or a scene with Template selection prefab and adjust the TemplateVersions property and run the scene to test.

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner May 10, 2024 12:26
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general

@HarrisonHough HarrisonHough merged commit 0ce2e1b into develop May 13, 2024
@HarrisonHough HarrisonHough deleted the feature/template-filter branch May 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants