Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-789] Small fix and minor improvements #215

Merged
merged 8 commits into from
Feb 7, 2024
Merged

[SDK-789] Small fix and minor improvements #215

merged 8 commits into from
Feb 7, 2024

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Feb 5, 2024 •
edited
Loading

SDK-789

Description

  • small fix for button icon resizing edgecase
  • some other minor improvements

How to Test

  • test by running the experimental cac example
  • to test the default avatar icons you'll need to add it to the scene and call the setup/loading functions manually

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner February 5, 2024 07:44
rk132
rk132 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment.

Runtime/AvatarCreator/Scripts/UI/Buttons/SelectionButton.cs Outdated
@@ -28,17 +28,18 @@ public void AddListener(Action action)
/// Sets the icon on the rawImage component
/// </summary>
/// <param name="texture">The texture to be assigned to the RawImage component</param>
/// <param name="sizeToParent">If true the icon will resize itself to fit inside the parent RectTransform</param>
/// <param name="keepAspectRatio">If true the icon will resize to match the texture's aspect ratio</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this

@HarrisonHough HarrisonHough merged commit 7a5cb4b into develop Feb 7, 2024
@HarrisonHough HarrisonHough deleted the feature/cac-improvements branch February 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132