Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-699] Add shader property in avatar config #199

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Jan 3, 2024

SDK-699

Description

  • Add custom shader property in avatar config
  • Removed avatar shadow from cac

How to Test

  • Load avatar with Avatar config standard shader set in avatar config in settings

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk requested a review from a team as a code owner January 3, 2024 14:12
@rYuuk rYuuk self-assigned this Jan 3, 2024
@rYuuk rYuuk changed the title Feature/remove avatar shadow cac [SDK-699] Add shader property in avatar config Jan 3, 2024
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks good.
1 improvement idea is that we could look at showing only shader properties (or rather texture channels) that have been enabled?
image
EG in this case only BaseColor would be visible under the Shader section

Also as mentioned in slack but maybe it makes sense to explore the gltfast instantiator approach for assigning materials/shaders to prevent the "double" assigning. Or at least test if doing this has any benefit performance wise

@rYuuk rYuuk merged commit e3e4c3d into develop Jan 8, 2024
@rYuuk rYuuk deleted the feature/remove-avatar-shadow-cac branch January 8, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants