Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-721] Add clearing of panel switcher #194

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[SDK-721] Add clearing of panel switcher #194

merged 1 commit into from
Jan 2, 2024

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Dec 20, 2023 •
edited
Loading

SDK-721

Description

  • Added clear functionality in panel switcher, which will be called onDestroy

How to Test

  • Try to Load scene twice from a different scene

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Dec 20, 2023
@rYuuk rYuuk requested a review from a team as a code owner December 20, 2023 14:49
HarrisonHough
HarrisonHough approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Nice work

@rYuuk rYuuk merged commit 94aee60 into develop Jan 2, 2024
4 checks passed
@rYuuk rYuuk deleted the feature/add-panel-switcher-clear branch January 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough