Release/v4.1.0 #170
Merged
Release/v4.1.0 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [SDK-588](https://ready-player-me.atlassian.net/browse/SDK-588) ## Description - Updated render api - Updated samples and tests
## [SDK-513](https://ready-player-me.atlassian.net/browse/SDK-513) ## Description - Added app id to setup guide
<!-- Copy the TICKETID for this task from Jira and add it to the PR name in brackets --> <!-- PR name should look like: [TICKETID] My Pull Request --> <!-- Add link for the ticket here editing the TICKETID--> ## [SDK-472](https://ready-player-me.atlassian.net/browse/SDK-472) ## Description - Replace API URLs with model URLs for shortcodes <!-- Fill the section below with Added, Updated and Removed information. --> <!-- If there is no item under one of the lists remove it's title. --> <!-- Testability --> ## How to Test - Add steps to locally test these changes <!-- Update your progress with the task here --> ## Checklist - [ ] Tests written or updated for the changes. - [ ] Documentation is updated. - [ ] Changelog is updated. <!--- Remember to copy the Changes Section into the commit message when you close the PR --> [SDK-472]: https://ready-player-me.atlassian.net/browse/SDK-472?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
HarrisonHough
force-pushed
the
release/v4.1.0
branch
from
87d7caf to
a62da19
Compare
I tried to add a unit test, but the static nature of a lot of the Unity SDK made this very difficult. I think we should spend some time on making the SDK more testable soon, perhaps installing something like Moq so we can at least mock out some of the more awkward dependencies as a starting point to test stuff in isolation -> https://docs.unity3d.com/Packages/[email protected]/manual/index.html I've also include a little bit of tidying up in the classes I've touched in this PR. Ignore all the commits, I will squash upon merging 😅. 
## Description - The model namespace caused PackageCoreInfo.cs to no come in same asmdef, hence causing error when it was used outside of this asmdef. - I made it simpler by removing redundant code and using simple string type.
HarrisonHough
force-pushed
the
release/v4.1.0
branch
from
18cef79 to
21f02d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKETID
Description
How to Test
https://github.com/readyplayerme/rpm-unity-sdk-core.git#release/v4.1.0Checklist