Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-411] Update app id missing error message #153

Merged
merged 3 commits into from
Nov 15, 2023
Merged

[SDK-411] Update app id missing error message #153

merged 3 commits into from
Nov 15, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Nov 14, 2023 •
edited by jira bot
Loading

SDK-411

Description

  • Updated app id missing error message when avatar creator sample is run

How to Test

  • Set app id in settings to empty and run avatar creator sample

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Nov 14, 2023
@rYuuk rYuuk requested a review from a team as a code owner November 14, 2023 06:07
@rYuuk rYuuk closed this Nov 14, 2023
@rYuuk rYuuk reopened this Nov 14, 2023
HarrisonHough
HarrisonHough approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A noiz smol PR !

Samples~/AvatarCreatorSamples/Scripts/UI/AvatarCreatorStateMachine.cs Show resolved Hide resolved
@MaxAndreassenRPM MaxAndreassenRPM merged commit fe19c66 into develop Nov 15, 2023
5 checks passed
@MaxAndreassenRPM MaxAndreassenRPM deleted the feature/appid-missing-error-message branch November 15, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rYuuk @HarrisonHough @MaxAndreassenRPM