Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-544] feat: update context menu ordering to add separators #129

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[SDK-544] feat: update context menu ordering to add separators #129

merged 1 commit into from
Oct 12, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Oct 10, 2023 •
edited by jira bot
Loading

SDK-544

Description

  • update menu item priority for better separation
  • also moved the Unity-SDK only menu items (internal dev functions) into a separate RPM Tools section. This enables us to cleanup Ready Player Me section and also see exactly what developers would see after importing the package into a project

Screenshot 2023-10-10 082817

Screenshot 2023-10-10 082813

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team October 10, 2023 05:36
@HarrisonHough HarrisonHough requested a review from rYuuk as a code owner October 10, 2023 05:36
rYuuk
rYuuk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Unity works in mysterious ways

@HarrisonHough HarrisonHough merged commit bfc83d5 into develop Oct 12, 2023
4 checks passed
@HarrisonHough HarrisonHough deleted the feature/update-context-menu branch October 12, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAndreassenRPM MaxAndreassenRPM MaxAndreassenRPM approved these changes

@rYuuk rYuuk rYuuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarrisonHough @rYuuk @MaxAndreassenRPM