Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-414]Feature/extract webview logic #125

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Sep 22, 2023

SDK-414

Description

How to Test

  • import this branch in a fresh project or checking out Unity SDK
  • NOTE: to prevent errors you will also need to checkout/import the feature branch for webview that also includes these changes feature/extract-shared-functionality
  • also test the Core WebGL example as that uses some of these classes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough force-pushed the feature/extract-webview-logic branch from 8dbcade to 7e130f8 Compare September 22, 2023 07:35
HarrisonHough added a commit to readyplayerme/rpm-unity-sdk-webview that referenced this pull request Sep 28, 2023
-   moved shared data and classes to Core package
- - this is linked to this PR for Core readyplayerme/rpm-unity-sdk-core#125
@HarrisonHough HarrisonHough merged commit f972732 into develop Sep 28, 2023
@HarrisonHough HarrisonHough deleted the feature/extract-webview-logic branch September 28, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants