-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Visit docs button to header #508
base: main
Are you sure you want to change the base?
Conversation
This gives a basic way to get to the docs like the old dashboard. I think this is important and is a middle ground until we can work on a fancier verison.
The reason I have been -1 on this approach is because it creates two view docs buttons on the build detail page. The top most button will go to the wrong docs too (latest) instead of the PR build/branch docs for the build. I still think this should be a singular button |
This button will eventually move to the project wide header, here:
A temporary solution until someone wants to make this into a dropdown would be to move the current view docs button in the build detail page up to a I still feel a dropdown is the best UX here and is my overall goal still. |
For now, I've just hidden the View docs button on build pages, which seems like a reasonable approach? |
We talked through this one in person, I mentioned:
The answer here does need to be more complex. A web component fits here short and long term, I'm poking something more flexible now. |
I think this is still worth getting in, especially now that we are pointing folks to this. I think my current PR solves this problem in a simple way for now, and we can do the v2 later when we have more time to dive into it? |
Ping @agjohnson -- 👍 on shipping this simple version for now, and we can work to make it the better smart version in the future? |
This gives a basic way to get to the docs like the old dashboard. I was doing a bunch of local dev on the new dashboard and kept getting annoyed at not being able to get to the docs in an obvious way.
I think this is important and is a middle ground until we can work on a fancier verison.