Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In docs Modal is not dismissed by pressing Esc #537

Open
mbohal opened this issue Apr 19, 2024 · 1 comment · May be fixed by #544
Open

In docs Modal is not dismissed by pressing Esc #537

mbohal opened this issue Apr 19, 2024 · 1 comment · May be fixed by #544
Assignees
@bedrich-schindler
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
v1.0.0

Comments

@mbohal
Copy link
Contributor

mbohal commented Apr 19, 2024

Likely it is related to the documentation platform and not the component itself as it seems to work in app.

Also the fix might need to be ported to RADES.
@mbohal mbohal added bug Something isn't working documentation Improvements or additions to documentation labels Apr 19, 2024
@mbohal mbohal added this to The Board Apr 19, 2024
@github-project-automation github-project-automation bot moved this to 💡Ideas in The Board Apr 19, 2024
@mbohal mbohal moved this from 💡Ideas to 🔖 To do in The Board Apr 19, 2024
@adamkudrna adamkudrna linked a pull request Jun 17, 2024 that will close this issue
Open
@adamkudrna
Copy link
Member

This is fixed in #544.

@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bedrich-schindler bedrich-schindler

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
The Board
Status: 👀 In review
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Re-implement Modal component using HTMLDialogElement (#461) react-ui-org/react-ui
3 participants
@mbohal @adamkudrna @bedrich-schindler