Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakRef support #741

Closed
phryneas opened this issue Dec 6, 2023 · 5 comments
Closed

WeakRef support #741

phryneas opened this issue Dec 6, 2023 · 5 comments

Comments

@phryneas
Copy link

phryneas commented Dec 6, 2023

Introduction

Hermes has support for WeakRefs, but it seems it's not enabled for React Native.

Details

From facebook/hermes#658 and facebook/hermes#1195, it seems that this requires action on the React Native side (enabling the microtask-queue flag for Hermes and then routinely calling drainMicrotasks).

Discussion points

Is there a reason why microtask-queue is not enabled, and could it be enabled?

@cortinico
Copy link
Member

Thanks for flagging this. Let's keep the conversation on:

The Hermes team is aware of this + we'll have to do some integration work on the React Native side. This is currently under our radar but we don't have an ETA

@Yonom
Copy link

Yonom commented Jan 7, 2024

@cortinico The linked issue has been closed:

Closing, because there is nothing more to be done about this in Hermes.

I couldn't find any open issues regarding RN support of WeakRefs.
Perhaps it makes sense to reopen this one to track react native support?

@pilotniq
Copy link

pilotniq commented Jan 27, 2024

@cortinico Yes, please re-open this issue, so that we can follow the progress!

@CptKicks
Copy link

+1 - Please re-open the issue

@cortinico
Copy link
Member

I've opened this one to keep the conversation going:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants