New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probe why merging props behave weridly if _.get function is not spread #12

Open

kulkarnisaumitra98 opened this issue Jan 2, 2021 · 0 comments

Assignees

Contributor

kulkarnisaumitra98 commented Jan 2, 2021

const finalProps: typeof themeOverrideProps = merge(
    { ...get(theme, `picker.${props.variant || 'default'}`, {}) },
    themeOverrideProps
  );

Need to spread get function in order for merging to work. Probe this.

kulkarnisaumitra98 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment