Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeProps allows number for pushable #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RangeProps allows number for pushable #725

wants to merge 1 commit into from

Commits on Dec 17, 2020

  1. RangeProps allows number for pushable 

    The top-level `README` describes the `pushable` prop of `Range` as `boolean` or `number` (or `undefined`), but the type annotation in `Range.tsx` is `pushable?: boolean;`. When developing with `rc-slider` in Typescript, using for example `pushable={5}` causes a type error, and the only way around this is `pushable={(5 as unknown) as undefined}` which then produces the expected behaviour. This type annotation appears to be incorrect and would be great to have it updated.
    @RobertMurrayImprobable
    RobertMurrayImprobable authored Dec 17, 2020
    Configuration menu
    Copy the full SHA
    fe784c3 View commit details
    Browse the repository at this point in the history