1197 npm build warnings in ci #1203
Conversation
There was a problem hiding this comment.
Very nice thanks for looking into it. However, I don't want the profile hints in watch mode. But I want the export 'default' warning. I thought about adding a warningsConfig in webpack.config.js, but not if args.watch is set. Or we add a build:testing with a testingConfig. What do you think?
|
yeah, also thought about adding another config. By adding a |
|
Yes, and |
MyPyDavid
force-pushed
the
1197-npm-build-warnings-in-ci
branch
from
9bc5100
to
48c2de7
Compare
package.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "name": "rdmo", | |||
| "scripts": { | |||
| "build:prod": "webpack --config webpack.config.js --mode production", | |||
There was a problem hiding this comment.
I would suggest that build:prod fails on warnings and testing does not, but contains the performance hints.
There was a problem hiding this comment.
Ive added an object ignorePerformanceWarnings that build:prod gets so that it can fail on other warnings
package.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "name": "rdmo", | |||
| "scripts": { | |||
| "build:prod": "webpack --config webpack.config.js --mode production", | |||
| "build:testing": "webpack --config webpack.config.js --mode production --env testing --fail-on-warnings", | |||
There was a problem hiding this comment.
Why not just --mode testing and add 'process.env.NODE_ENV': JSON.stringify('testing')?
webpack.config.js
Outdated
| } else { | ||
| return merge(config, baseConfig, productionConfig) | ||
| throw new Error( |
There was a problem hiding this comment.
To much complexity production can be the fallback and should be very strict, but still needs to allow for larger files.
There was a problem hiding this comment.
yes, refactored it into a switch case, I don't see the need for a fallback when it should not be receiving any other mode..
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
1197-npm-build-warnings-in-ci
branch
from
48c2de7
to
dff1508
Compare
Description
Related issue: #1197
Motivation and Context
How has this been tested?
Screenshots (if appropriate)