Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all catalogs #1201

Draft
wants to merge 5 commits into
base: 2.3.0
Choose a base branch
from
Draft

Show all catalogs #1201

wants to merge 5 commits into from
+16 −4

Conversation

CalamityC
Copy link
Collaborator

Description

Related issue: #ISSUE_NUMBER

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

@CalamityC CalamityC changed the base branch from main to 2.3.0 November 26, 2024 15:35
jochenklar
jochenklar requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny thing, if the non-available catalog is selected it is barely readable (dark-gray on blue). Can you add a css rule to make text-muted white when active?

jochenklar
jochenklar approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochenklar jochenklar jochenklar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalamityC @jochenklar