feat(copy project): Add copy project functionality and refactor project hierarchy validation #1133
+734
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenklar
force-pushed
the
copy-project
branch
from
76cdf0a
to
862fa8b
Compare
jochenklar
force-pushed
the
copy-project
branch
from
9898f90
to
61476b7
Compare
jochenklar
changed the title
jochenklar
changed the title
jochenklar
force-pushed
the
copy-project
branch
from
61476b7
to
97534ba
Compare
|
tests need to be fixed, then this one should be merged before interview PRs |
|
ah with mysql I can reproduce locally the failing tests: maybe it has to do with |
MyPyDavid
reviewed
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to copy projects. There is a new
ProjectCopyViewand acopyaction in theProjectViewSet. To make it work a newProjectParentValidatorneeds to be added, since the old way to prevent that a project is set to be a child of itself was not flexible enough. Some tests needed to be added and fixes as well.