feat(interview): Copy dataset [3] #1128
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenklar
force-pushed
the
interview-copy-dataset
branch
from
cdb35a2
to
1082398
Compare
jochenklar
force-pushed
the
interview-apply-to-all
branch
from
5c65410
to
498ae19
Compare
jochenklar
force-pushed
the
interview-copy-dataset
branch
from
1082398
to
40a8e80
Compare
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
approved these changes
Nov 8, 2024
jochenklar
changed the title
jochenklar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to copy tabs (i.e. datasets) or better to create a new tab with all values from the current tab. It works a bit like deleting a set. If a
set_valueis present (e.g.project/dataset/id), the catalog is used to get all values for the current set and copy them, along with a newset_value. For#style sets without attributes this is done in the front end. There is some black magic involved when theset_prefixof values is updated with theset_indexof the new set.