Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build and deploy pipeline for the docs #19

Open
MyPyDavid opened this issue Nov 10, 2022 · 5 comments
Open

Add a build and deploy pipeline for the docs #19

MyPyDavid opened this issue Nov 10, 2022 · 5 comments

Comments

@MyPyDavid
Copy link
Member

MyPyDavid commented Nov 10, 2022

I think the last merged PR is not yet deployed to https://rdmo.readthedocs.io/, there is no mention of "Keycloak" yet https://rdmo.readthedocs.io/en/latest/search.html?q=keycloak&check_keywords=yes&area=default.

Suggestion: It would be easier to have here a pipeline installed via the Github Actions or via a webhook integration:

@MyPyDavid
Copy link
Member Author

@jochenklar
Copy link
Member

We could also drop readthedocs (because of the advertisement) and deploy it to rdmorganiser.github.io/docs/ or even move everything to rdmo.org, which I accidentally own 😁 .

@afuetterer
Copy link
Member

What do you prefer?

  • rdmo.readthedocs.io
  • rdmorganiser.github.io/rdmo <- docs could move to rdmo repo again and be built and deployed on each release on master
  • rdmorganiser.github.io/docs
  • rdmo.org

I would stick with GitHub pages or readthedocs.

Did you decide on having "only" the latest docs online?

I am confused about the usage of RDMO_VERSION in the docs, which is only rendered locally but shown as latest on rtd.

https://github.com/rdmorganiser/rdmo-docs-en/blob/068696278b7dbb54477ecf71b44903cc3978770d/docs/conf.py#L3

@afuetterer
Copy link
Member

afuetterer commented Oct 18, 2023

If there should be no deploy pipeline for the docs, I would still propose adding a CI job to lint, build and linkcheck. What do you think?

e.g. ruff (only conf.py, maybe overkill), markdownlint (for the md files), and pre-commit hooks for trailing whitespace etc.

@jochenklar
Copy link
Member

I like rdmorganiser.github.io/docs but then we need some kind of dummy repo to guide users from rdmo.readthedocs.io to that page. (or a redirect). We would get rid of the ads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants