Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items that I would like to discuss. #1

Open
rsunbury opened this issue Nov 5, 2019 · 1 comment
Open

Items that I would like to discuss. #1

rsunbury opened this issue Nov 5, 2019 · 1 comment

Comments

@rsunbury
Copy link

rsunbury commented Nov 5, 2019

Here are some items I would like to discuss further.

3.7 Do not call Object.prototype methods directly, such as hasOwnProperty, propertyIsEnumerable, and isPrototypeOf. eslint: no-prototype-builtins
3.8 Prefer the object spread operator over Object.assign to shallow-copy objects. Use the object rest operator to get a new object with certain properties omitted.
6.2 Strings that cause the line to go over 100 characters should not be written across multiple lines using string concatenation.
6.3 When programmatically building up strings, use template strings instead of concatenation. eslint: prefer-template template-curly-spacing
7.1 Use named function expressions instead of function declarations. eslint: func-style
7.13 Never reassign parameters. eslint: no-param-reassign Note: not sure why this would be a problem with primitives.
13.6 Avoid using unary increments and decrements (++, --). eslint no-plusplus
19.12 Add spaces inside curly braces. eslint: object-curly-spacing Note: why is this different from 19.10 and 19.11?
20.2 Additional trailing comma: Yup. eslint: comma-dangle
No brace for single line block. Need to discuss.

@rchrdw
Copy link
Owner

rchrdw commented Nov 5, 2019

3.7 Do not call Object.prototype methods directly, such as hasOwnProperty, propertyIsEnumerable, and isPrototypeOf. eslint: no-prototype-builtins

This only applies to hasOwnProperty, isPrototypeOf, and propertyIsEnumerable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants